Skip to content

chore: change registration name to unleash-ios-sdk #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gastonfournier merged 1 commit into from
Aug 7, 2025
Merged

chore: change registration name to unleash-ios-sdk #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/UnleashProxyClientSwift/Metrics/Metrics.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public class Metrics {
request.addValue(clientKey, forHTTPHeaderField: "Authorization")
request.addValue(appName, forHTTPHeaderField: "unleash-appname")
request.addValue(connectionId.uuidString, forHTTPHeaderField: "unleash-connection-id")
request.setValue("unleash-client-swift:\(LibraryInfo.version)", forHTTPHeaderField: "unleash-sdk")
request.setValue("unleash-ios-sdk:\(LibraryInfo.version)", forHTTPHeaderField: "unleash-sdk")
if !customHeaders.isEmpty {
for (key, value) in customHeaders {
request.setValue(value, forHTTPHeaderField: key)
Expand Down
2 changes: 1 addition & 1 deletion Sources/UnleashProxyClientSwift/Poller/Poller.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public class Poller {
request.setValue(currentEtag, forHTTPHeaderField: "If-None-Match")
request.setValue(appName, forHTTPHeaderField: "unleash-appname")
request.setValue(connectionId.uuidString, forHTTPHeaderField: "unleash-connection-id")
request.setValue("unleash-client-swift:\(LibraryInfo.version)", forHTTPHeaderField: "unleash-sdk")
request.setValue("unleash-ios-sdk:\(LibraryInfo.version)", forHTTPHeaderField: "unleash-sdk")

let customHeaders = self.customHeaders.merging(self.customHeadersProvider.getCustomHeaders()) { (_, new) in
new
Expand Down
4 changes: 2 additions & 2 deletions Tests/UnleashProxyClientSwiftTests/PollerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ final class PollerTests: XCTestCase {
XCTAssertEqual(request.value(forHTTPHeaderField: "X-Another-Header"), "AnotherValue")
XCTAssertEqual(request.value(forHTTPHeaderField: "unleash-appname"), "APPNAME")
XCTAssertEqual(request.value(forHTTPHeaderField: "unleash-connection-id"), "123E4567-E89B-12D3-A456-426614174000")
XCTAssertTrue(request.value(forHTTPHeaderField: "unleash-sdk")!.range(of: #"^unleash-client-swift:\d+\.\d+\.\d+$"#, options: .regularExpression) != nil, "unleash-sdk header sdk:semver format does not match")
XCTAssertTrue(request.value(forHTTPHeaderField: "unleash-sdk")!.range(of: #"^unleash-ios-sdk:\d+\.\d+\.\d+$"#, options: .regularExpression) != nil, "unleash-sdk header sdk:semver format does not match")
expectation.fulfill()
}

Expand All @@ -228,7 +228,7 @@ final class PollerTests: XCTestCase {
XCTAssertEqual(request.value(forHTTPHeaderField: "X-Another-Header"), "AnotherValue-2")
XCTAssertEqual(request.value(forHTTPHeaderField: "unleash-appname"), "APPNAME")
XCTAssertEqual(request.value(forHTTPHeaderField: "unleash-connection-id"), "123E4567-E89B-12D3-A456-426614174000")
XCTAssertTrue(request.value(forHTTPHeaderField: "unleash-sdk")!.range(of: #"^unleash-client-swift:\d+\.\d+\.\d+$"#, options: .regularExpression) != nil, "unleash-sdk header sdk:semver format does not match")
XCTAssertTrue(request.value(forHTTPHeaderField: "unleash-sdk")!.range(of: #"^unleash-ios-sdk:\d+\.\d+\.\d+$"#, options: .regularExpression) != nil, "unleash-sdk header sdk:semver format does not match")
expectation.fulfill()
}

Expand Down
Loading