feat: improve error handling in metrics and fetch toggles#264
Merged
chriswk merged 2 commits intoUnleash:mainfrom Sep 9, 2025
Merged
feat: improve error handling in metrics and fetch toggles#264chriswk merged 2 commits intoUnleash:mainfrom
chriswk merged 2 commits intoUnleash:mainfrom
Conversation
chriswk
approved these changes
Sep 9, 2025
Member
chriswk
left a comment
chriswk
left a comment
There was a problem hiding this comment.
This makes sense to me. Thank you @gabrielduete . We'll get this merged and published.
github-project-automation
bot
moved this from In Progress
to Approved PRs
in Issues and PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the changes
Closes #263 | Unleash/unleash#10620
Important files
src/index.ts
Discussion points
This pull request improves error event handling in the
UnleashClientclass to provide more context about where errors originate. Now, when an error is emitted, it includes atypefield indicating the source of the error, making it easier to debug and handle errors appropriately.Enhanced error event payloads:
onErrorhandler in theMetricsinstantiation to emit errors with a payload containing the error type ('metrics') and the error object, instead of just the error.'fetch-toggles') and the error object, instead of just the error.