fix: pass year and month parameters to class events for attendance#1035
Merged
fix: pass year and month parameters to class events for attendance#1035
Conversation
calisio
requested changes
Nov 6, 2025
Contributor
calisio
left a comment
calisio
left a comment
There was a problem hiding this comment.
one small fix - if you click on the cancel button then it doesn't take you back to the right month. Besides that, looks and works great.
Member
Author
I could have swore I made sure to take care of cancel :@ Must have just thought about it, and not done it. I'll take care of it right now. Thank you! |
calisio
approved these changes
Nov 7, 2025
carddev81
approved these changes
Nov 11, 2025
Contributor
carddev81
left a comment
carddev81
left a comment
There was a problem hiding this comment.
tested great and looks good!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
After saving or cancelling the taking of attendance the application would redirect the user to the current month, not the month that they were on. This PR makes sure that the month and year are passed appropriately inso that we make sure the user lands on the appropriate month upon their attendance action.
Additional context
For context: The ClassEvents component initialized the currentMonth state to the current date and never reads the query parameters. When EventAttendance navigated the params were ignored.