feat: add attendance rate card to program overview to fill space and per users request#1082
Open
feat: add attendance rate card to program overview to fill space and per users request#1082
Conversation
…per users request
carddev81
force-pushed
the
carddev81/ticket_id572_attendance
branch
from
91a23a0 to
762e324
Compare
corypride
requested changes
Feb 13, 2026
Contributor
corypride
left a comment
corypride
left a comment
There was a problem hiding this comment.
Looks good, minor fixes mentioned above and gtg!
| label="%" | ||
| /> | ||
| <StatsCard | ||
| title="Avg Attendance Rpate" |
|
|
||
| const status = getProgramStatus(program, user?.facility.id); | ||
| const canAddClass = status === 'active'; | ||
| const attendanceRate: number | string | undefined = |
Contributor
There was a problem hiding this comment.
const attendanceRate: number | string | undefined =
typeof program?.attendance_rate === 'number' ||
typeof program?.attendance_rate === 'string'
? program.attendance_rate
: undefined;
This seems redundant since the model defines attendance_rate as number. Unless there's a specific reason for this check, could it can be simplified to just accessing program?.attendance_rate or even program?.attendance_rate ?? undefined;?
Contributor
Author
There was a problem hiding this comment.
i'll make sure and make the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission PR Checklist
Description of the change
Added a card to display the Attendance Rate within the Program Overview per users' request.
Screenshot(s)