Skip to content

Pprados/fix pdfminer dep #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 20, 2025
Merged

Pprados/fix pdfminer dep #410

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ee62dc4
Add password with PDF files
pprados Oct 15, 2024
454cb35
Merge branch 'main' into pprados/fix_password
pprados Oct 24, 2024
16776f3
Merge branch 'main' into pprados/fix_password
pprados Oct 25, 2024
ed43d82
Add TU
pprados Oct 29, 2024
ce13fa1
merge with main
pprados Dec 10, 2024
fd35cb3
Merge branch 'main' into pprados/fix_password
Coniferish Jan 19, 2025
ecc95eb
Fix CHANGELOG.md
pprados Jan 20, 2025
feea1f8
Add password with PDF files
pprados Oct 15, 2024
70be207
Add TU
pprados Oct 29, 2024
ee93ee2
merge with main
pprados Dec 10, 2024
458f05b
Fix CHANGELOG.md
pprados Jan 20, 2025
c3ca1dd
Fix make check
pprados Jan 20, 2025
d276d6e
Merge remote-tracking branch 'origin/pprados/fix_password' into pprad…
pprados Jan 20, 2025
71bb5f7
Merge branch 'main' into pprados/fix_password
pprados Jan 21, 2025
ee6e638
Merge branch 'main' into pprados/fix_password
Coniferish Jan 23, 2025
307e901
Merge, make tidy and fix CHANGELOG.md
pprados Jan 30, 2025
cdd4fef
Fix __version__.py
pprados Jan 30, 2025
30805b8
Fix mypy
pprados Jan 30, 2025
de80975
use unstructured-inference 0.8.7
pprados Feb 4, 2025
e4a08f9
Fix pdfminer-six dependencies
pprados Feb 12, 2025
2e9a149
Merge branch 'main' of https://github.com/Unstructured-IO/unstructure…
pprados Feb 13, 2025
75f74cc
Merge branch 'upstream/main' into pprados/fix_pdfminer_dep
pprados Feb 13, 2025
cff2c7b
Update CHANGELOG.md
Coniferish Feb 13, 2025
64ecdc0
Update unstructured_inference/__version__.py
Coniferish Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.8.8-dev1

* fix: pdfminer-six dependencies

## 0.8.7

* fix: add `password` for PDF
Expand Down
2 changes: 1 addition & 1 deletion requirements/base.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ rapidfuzz
pandas
scipy
pypdfium2
pdfminer-six==20240706
pdfminer-six>=20240706
Copy link
Contributor

@cragwolfe cragwolfe Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this always resolve to the same package, currently the latest one? just remove the pin altogether?

Copy link
Contributor Author

@pprados pprados Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but in future the following versions will be mandatory.

Langchain follows the evolution of versions for PDFMinerLoader and it will not be possible to combine it with unstructured.
The final objective of my series of Pull Request for LangChain is to be able to choose the parser for each case, with PDFRouterLoader. This means being able to have several parsers at the same time. Freezing a version prevents this.

no problem for you to do it yourself.
Take this opportunity to publish a new version, and adjust, in unstructured, extra-pdf-image.in, with the new version.

Copy link
Contributor

@Coniferish Coniferish Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an fyi, @cragwolfe, but the initial pin for pdfminer-six was added just a few weeks ago when removing pdfplumber (here) to maintain required packages used by scripts to pass CI. It sounds like it's a workaround we might want to fix. For easy reference, though, here's extra-pdf-image.in

@pprados, I'm confused what you're saying needs to be adjusted in extra-pdf-image.in. The pdfminer.six version isn't pinned there, so it should be install the latest as @cragwolfe mentioned, right?

Copy link
Contributor

@Coniferish Coniferish Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cragwolfe, if this PR looks good to you, can you approve my duplicate PR here? The CI failure in this one is due to a secret that's needed in CI itself and not just particular tests, so I'm unsure how to fix that for contributor PRs at the moment.

2 changes: 1 addition & 1 deletion unstructured_inference/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.8.7" # pragma: no cover
__version__ = "0.8.8-dev1" # pragma: no cover
Loading