enhancement: add text sources #449
Merged
+299
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
badGarnet
reviewed
Nov 4, 2025
Comment on lines
+253
to
+255
| # NOTE(alan): I would expect if I try to access a single element, it should return a | ||
| # TextRegion, not a TextRegions. Currently, you get an error when trying to access a single | ||
| # element. |
There was a problem hiding this comment.
this can be a new ticket/issue
There was a problem hiding this comment.
badGarnet
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
TextSourcefor tracking source of element text.Note
Introduces
IsExtractedacrossTextRegion/TextRegions/LayoutElement(s)with refactored auto-initialization, updates slicing/concat/cleaning/equality to carry the flag and sources, and bumps version to 1.1.0.IsExtractedenum; extendTextRegionwithis_extractedandfrom_coords(..., is_extracted=...).TextRegions.__post_init__to auto-initialize optional arrays from scalar fields (source→sources,is_extracted→is_extracted_array).from_listpreservesourcesandis_extracted_array.is_extractedthroughLayoutElement/LayoutElements(to_dict,from_region,from_coords,from_list,concatenate,iter_elements,slice,__eq__).is_extracted_arrayin cleaning utilities (clean_layoutelements*) and concatenation outputs.sourcesandis_extractedpropagation, slicing,from_list, and inheritance behavior.1.1.0and updateCHANGELOG.md.Written by Cursor Bugbot for commit 03af14e. This will update automatically on new commits. Configure here.