fix: Prepare for breaking change in upcoming unstructured-client #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the unreleased 0.30.0 of `unstructured-client`, handling of the `server_url` is changing. We need to do this to integrate the platform API functions. Now, different parts of the SDK are talking to different backend services, and so it's preferred that we set the `server_url` per endpoint. Note that for compatibility with the current SDK, we need to strip the `/general/v0/general` path off of the URL. We have logic to do this in the SDK, but in versions before 0.30.0 this doesn't take effect when you pass the URL in the endpoint like this.
awalker4
force-pushed
the
NEXUS-777/python-client-url
branch
from
1b0a8c4 to
02cddf4
Compare
PastelStorm
reviewed
Feb 12, 2025
|
|
||
| # Note(austin) - the sdk takes the base url, but users may pass the full endpoint | ||
| # For consistency, strip off the path when it's given | ||
| base_url = server_url[:-19] if "/general/v0/general" in server_url else server_url |
There was a problem hiding this comment.
Would be safer to split on /general/v0/general in case there are trailing spaces or tabs.
There was a problem hiding this comment.
Also server_url is an optional parameter, so it would make sense to check if it exists.
raiderrobert
changed the title
|
Closing in preference of an upstream fix: Unstructured-IO/unstructured-python-client#226 |
auto-merge was automatically disabled
February 18, 2025 20:48
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unreleased 0.30.0 of
unstructured-client, handling of theserver_urlis changing. We need to do this to integrate the platform API functions. Now, different parts of the SDK are talking to different backend services, and so it's preferred that we set theserver_urlper endpoint.Note that for compatibility with the current version, we need to strip the
/general/v0/generalpath off of the URL. We have logic to do this in the SDK, but in versions before 0.30.0 this only applies to theserver_urlpassed to the client instance. So, it's a bit of a chicken and egg. Once 0.30.0 is published and pulled in this repo, we can remove these lines if we want.Related core library fix: Unstructured-IO/unstructured#3916