chore Use pdf library to check file without extension #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same comment as Unstructured-IO/unstructured-python-client#184 - can you also remove the console.warn and console.error in the catch block? Sending a doc file with those logs shows a scary exception from PDFDocument.load |
yuming-long
changed the title
yuming-long
deleted the
yuming/RUDOLPH-98_pdf_split_not_relay_on_file_extend_js
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of manually checking filename with
.pdfextension and return is_pdf = false -> use currently pdf library to read file content to decide if the file content is valid pdf