fixed input to extractImageBlockType to be sent to the server properly #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalker4
approved these changes
Oct 2, 2024
Contributor
Author
Thought about this - I don't think it would be safe to assume say, searching over the form object and if it contains ",", that we could assume it needs to be converted to an actual list. I think we have to take it case by case and explicitly clean up the input unfortunately. |
awalker4
added a commit
that referenced
this pull request
May 29, 2025
Fixes #135 The SDK sends the wrong formdata when the user adds an array param. For instance, the following call: ``` client.general.partition({ partitionParameters: { files: { content: data, fileName: filename }, extractImageBlockTypes: ["Image", "Table"], } }) ``` Sends the list as one comma separated FormData value: `extract_image_block_types: "Image,Table"'. The server will ignore this unless it's sent with multiple keys like so: `extract_image_block_types[]: "Image", extract_image_block_types[]: "Table"` We addressed this before in #122 by adjusting the request body before sending it, but this code path is for pdf splitting. A better solution is to add a new hook that will clean up the form data for every request. Then we can remove the modification in the splitting code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This PR fixes the input for
extractImageBlockTypeto be sent as an array instead of a comma-delimited string so that the input settings are respected server side.Testing
Manually inspected server-side after change that the correct input is sent properly.
Updated integration test.