Skip to content

Conversation

@Coniferish
Copy link
Contributor

@Coniferish Coniferish commented Oct 3, 2024

Adds from __future__ import annotations to all custom code files to enable forward references to contemporary type hints such as dict and list. Also fixes a TypeAlias and enables python 3.8 checks (resolves #138)

@Coniferish Coniferish force-pushed the jj/annotations branch 2 times, most recently from 7c51d34 to 6a6235a Compare October 3, 2024 21:32
@Coniferish Coniferish changed the title chore: add annotations import to human-written code feat: py 3.8 support Oct 3, 2024
@Coniferish Coniferish requested a review from awalker4 October 3, 2024 22:06
Copy link
Collaborator

@awalker4 awalker4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Coniferish Coniferish merged commit 6e1fa29 into main Oct 4, 2024
9 checks passed
@Coniferish Coniferish deleted the jj/annotations branch October 4, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug/py3.8 compatibility

3 participants