increase max concurrency to 50 #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Tested concurrency settings with a 2500 page PDF.
Notes on various settings:
15 threads: 29 minutes
50 threads: 11 minutes
150 threads: 5 minutes
Memory usage:
15 threads:
Partition of a set of 530464 objects. Total size = 150187404 bytes. (~150MB)
50 threads:
Partition of a set of 530606 objects. Total size = 150206646 bytes. (~150MB)
150 threads:
Partition of a set of 530654 objects. Total size = 150221029 bytes. (~150MB)
For now proposing we increase this to a max of 50. We can always keep increasing later.