adding logic to trim pages that are too large to process #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-homan
force-pushed
the
add_page_split_logic_pdf
branch
3 times, most recently
from
3608682 to
3e15249
Compare
jordan-homan
force-pushed
the
add_page_split_logic_pdf
branch
from
3e15249 to
241da00
Compare
jordan-homan
changed the title
Klaijan
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Ran the test by locally pip install -v -e . the checked out PR.
INFO: HTTP Request: GET https://api.unstructuredapp.io/general/docs "HTTP/1.1 200 OK"
INFO: HTTP Request: POST https://api.unstructuredapp.io/general/v0/general "HTTP/1.1 200 OK"
INFO: HTTP Request: POST https://api.unstructuredapp.io/general/v0/general "HTTP/1.1 200 OK"
Runtime type is 'ModelMetaclass'
{'type': 'UncategorizedText', 'element_id': '0607d9a606c4a0d5355c730cea79e38a', 'text': '🔥', 'metadata': {'filetype': 'application/pdf', 'languages': ['eng'], 'page_number': 1, 'filename': 'super_long_pages.pdf'}}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Improves client logic when a PDF page is very long: trims the x/y coordinates down to a reasonable size (hi-res only). Note: this does not affect output of text: the reader is still able to process the entire page for text.
Testing
Manually tested changes on large file. Added integration test verifying large pages now process successfully.