feat: add a encrypt_secret helper function #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyMule
reviewed
Jul 1, 2025
CyMule
reviewed
Jul 2, 2025
| # Use the length of the public key to determine the encryption type | ||
| key_size_bytes = public_key.key_size // 8 | ||
| max_rsa_length = key_size_bytes - 66 # OAEP SHA256 overhead | ||
| print(max_rsa_length) |
There was a problem hiding this comment.
Suggested change
| print(max_rsa_length) |
nit
CyMule
reviewed
Jul 2, 2025
| """ | ||
| _, public_key_pem = rsa_key_pair | ||
|
|
||
| print(f"Testing plaintext of length {len(plaintext)} with expected type {secret_type}") |
There was a problem hiding this comment.
Suggested change
| print(f"Testing plaintext of length {len(plaintext)} with expected type {secret_type}") |
nit
CyMule
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
users.encrypt_secretthat conforms to Unstructured's secret formats. This will allow users to encrypt credentials locally before using them in connector config.