feat: improve PDF validation error handling with FileValidationError … #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpolomdeepsense
approved these changes
Jun 30, 2025
awalker4
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
LGTM! Just the one comment on the version, you can even leave it like this. The next time the Generate job runs, it will probably set the version at 0.37.3 anyway.
There was a problem hiding this comment.
This file is autogenerated - we can manually set the version in gen.yaml, and then it should take this the next time the SDK is rebuilt.
|
And yeah, I'd try the CI again. We have some ephemeral errors right now. Plus our integration tests are way too heavy in this repo so I'm not surprised if something timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…base class