Skip to content

Conversation

@awalker4
Copy link
Collaborator

@awalker4 awalker4 commented Jul 24, 2025

We have a generate failure because we've pulled general.py out for some custom changes. (See #270) This will hit the occasional bump as new code is added to this file upstream. The steps for fixing this:

  • Remove general.py from .genignore
  • Run speakeasy generate
  • Stage and commit the autogenerated changes, working around our custom code
  • Commit without the .genignore change

I set gen.yaml to version 0.41.0. This will cause the next generate job to propagate the new version and publish it.

We have a generate failure because we've pulled `general.py` out for some custom changes. This will
hit the occasional bump as new code is added to this file upstream. The steps for fixing this:

- Remove `general.py` from .genignore
- Run speakeasy generate
- Stage and commit the autogenerated changes, working around our custom code
- Commit without the `.genignore` change
@awalker4 awalker4 requested a review from CyMule July 24, 2025 19:20
@yuming-long
Copy link
Contributor

@claude a review please

@awalker4
Copy link
Collaborator Author

Uh oh, looks like we need a bit more work to enable it over here - https://github.com/Unstructured-IO/unstructured-python-client/actions/runs/16507745390/job/46682622133

In any case since most of this is autogenerated it may not be very helpful.

@yuming-long
Copy link
Contributor

hmm yeah i thought i enabled this already - i will follow up when crag is back :)

Copy link
Contributor

@yuming-long yuming-long left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


message: str
status_code: int
body: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi we raise body back to plugins as httpexception(detail=e.body)

Copy link
Contributor

@yuming-long yuming-long Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i think the message here could be something like
"API error occurred: Status 402 Content-Type application/json. Body: {\"detail\": \"api key Not found etc\"}"
which is too long for the error msg back to user

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would have preferred it if they didn't concatenate everything like that. At least body will still be the actual json so we can pull out the server response.

@awalker4 awalker4 merged commit 8e89995 into main Jul 25, 2025
19 checks passed
@awalker4 awalker4 deleted the austin/regenerate-sdk branch July 25, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants