8 visualization should be moved to separate modules#12
Open
JPchico wants to merge 3 commits intoUppASD:developfrom
Open
8 visualization should be moved to separate modules#12JPchico wants to merge 3 commits intoUppASD:developfrom
JPchico wants to merge 3 commits intoUppASD:developfrom
Conversation
added 3 commits
July 4, 2023 15:50
Adding an extra installation dependencies for the plotting.
Removing evals and global variables from the CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have moved the visualization to another module and gotten rid of the majority of the complains in the pre-commit.
The issues that remain seem to be about vtk complaining about not finding the names in a module. I wonder if this is real or it is a false positive, sometimes the imports can get a bit wonky with libraries such as vtk. I think that this is something that should be checked.