Skip to content

Putting the S on http for the ICS #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
altf4arnold wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Putting the S on http for the ICS #564

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57fe3e1
puting the secure in https
altf4arnold Jul 3, 2025
b750231
changing for a django template variable
altf4arnold Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion space/templates/map.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ <h3>Social</h3>
<i class="fa fa-youtube fa-stack-1x"></i>
</span>
</a>
<a href="http://urlab.be/events/urlab.ics" title="iCal" target="_blank">
<a href="https://urlab.be/events/urlab.ics" title="iCal" target="_blank">
Copy link
Member

@titouanc titouanc Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't a relative URL be sufficient here ?

Suggested change
<a href="https://urlab.be/events/urlab.ics" title="iCal" target="_blank">
<a href="{% url 'ical' %}" title="iCal" target="_blank">

See https://github.com/UrLab/incubator/blob/main/events/urls.py#L12

Copy link
Member Author

@altf4arnold altf4arnold Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work in testing

<span class="wow fa-stack fa-lg">
<i class="fa fa-square-o fa-stack-2x"></i>
<i class="fa fa-calendar fa-stack-1x"></i>
Expand Down
Loading