Skip to content

Unit tests for disabling scrollIntoView #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Unit tests for disabling scrollIntoView #87

wants to merge 1 commit into from

Conversation

@chestermjr
Copy link
Contributor

I recently added a PR for adding support for disabling scrollIntoView functionality. This PR adds unit tests. I also did a small refactor:

  • Previously, at the beginning of the _scrollSuggestionIntoView function, I returned early when shouldScrollIntoView property was false.
  • Now, instead, I am not calling _scrollSuggestionIntoView when shouldScrollIntoView property is false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chestermjr