Skip to content

Improve performance on queries with skipAddTrashCondition. #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ADmad merged 4 commits into from
Feb 3, 2025
Merged

Improve performance on queries with skipAddTrashCondition. #71

ADmad merged 4 commits into from
Feb 3, 2025

Conversation

@nicosp
Copy link
Contributor

@nicosp nicosp commented Jan 14, 2025 •
edited
Loading

  • Do not scan the query if we know we will not add the condition anyway.
  • Move query scanning to a function to allow users to override/skip it based on their requirements.

@nicosp
Copy link
Contributor Author

nicosp commented Feb 3, 2025

@ADmad ping

ADmad
ADmad reviewed Feb 3, 2025
View reviewed changes
ADmad
ADmad reviewed Feb 3, 2025
View reviewed changes
@nicosp
Fixes from PR and optimize findOnlyTrashed.
1b85a76 
Use options directly.
Use field IS instead of express.
@ADmad ADmad merged commit 9f4d333 into UseMuffin:master Feb 3, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADmad ADmad ADmad left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicosp @ADmad