Avoid unsafe to_camera_common_data() dereference #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_camera_common_data() actually parses the DT again and will return NULL if no sensor modes are defined. In this case it is unsafe to dereference the return value without previously checking for NULL.
I have a HDMI-CSI bridge chip used in parallel that doesn't define any sensor modes (since its only figured out at runtime), and the VC-MIPI changes were causing crashes. Sorry I didn't have a good setup to modify the patches properly, so it's inline.
For reference, to_camera_common_data from nvidia-oot/include/media/camera_common.h: