Skip to content

Minor adaptions to run with root 6.38#323

Merged
GernotMaier merged 14 commits intomainfrom
root-6.38
Dec 11, 2025
Merged

Minor adaptions to run with root 6.38#323
GernotMaier merged 14 commits intomainfrom
root-6.38

Conversation

@GernotMaier
Copy link
Copy Markdown
Member

@GernotMaier GernotMaier self-assigned this Dec 11, 2025
@GernotMaier GernotMaier marked this pull request as ready for review December 11, 2025 20:11
Copilot AI review requested due to automatic review settings December 11, 2025 20:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adapts the codebase to work with ROOT 6.38, addressing header file optimization changes introduced in that version. The changes include adding missing header includes that were previously transitively included, fixing a type mismatch in a function signature, updating the Docker infrastructure to use Ubuntu-based images, and updating CI workflows to match.

  • Adds explicit includes for <cmath> and TMath.h headers that are no longer transitively included in ROOT 6.38
  • Fixes a type mismatch in VPlotAnasumHistograms::drawPSF() where a string parameter incorrectly had an integer default value
  • Updates Docker images from AlmaLinux to Ubuntu and ROOT version from 6.30.02 to 6.32.04

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
inc/VPointingCorrectionsTreeReader.h Adds <cmath> include for atan2() function
inc/VPlotAnasumHistograms.h Fixes default parameter from integer 0 to empty string "" for string parameter
inc/VPedestalLowGain.h Adds TMath.h include for ROOT math functions
inc/VGlobalRunParameter.h Adds TMath.h include for ROOT math functions
docs/changes/323.maintenance.md Documents the ROOT 6.38 compatibility changes
dockerfiles/Dockerfile Updates base image from Alma9 to Ubuntu 24.04, ROOT version to 6.32.04, switches package manager from dnf to apt, improves shell quoting, and explicitly initializes LD_LIBRARY_PATH
.github/workflows/vts-eventdisplay-package.yml Adds YAML front matter (---) for proper YAML document formatting
.github/workflows/ci-buildmatrix-cpp17.yml Updates ROOT versions in test matrix, removes conditional logic for package installation (now all Ubuntu), switches to libopenblas-dev

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GernotMaier GernotMaier merged commit 0a8e450 into main Dec 11, 2025
13 checks passed
@GernotMaier GernotMaier deleted the root-6.38 branch December 11, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants