Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the XGBoost direction reconstruction code by extracting training variables into a shared module and adds telescope selection functionality for model application. The key changes include:
- Extracted training variables into a reusable
xgb_training_variables()function - Added telescope selection capability with support for bit-coded and comma-separated formats
- Enhanced the
apply_models()function to handle selective event processing - Added comprehensive test coverage for the new telescope selection features
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| python/training_variables.py | New module defining the xgb_training_variables() function to centralize training variable definitions |
| python/trainXGBoostforDirection.py | Refactored to use xgb_training_variables() from the new module, removing duplicate variable list |
| python/applyXGBoostforDirection.py | Added telescope selection parsing, filtering, and mask-based processing; refactored to use shared training variables |
| python/tests/test_applyXGBoostforDirection.py | New test file with comprehensive coverage for image selection parsing, filtering, and model application |
| pytest.ini | Configuration file to set Python path for pytest |
| environment.yml | Added pytest, pytest-cov, pytest-mock, and shellcheck dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.