Skip to content

3-telescope XGB#328

Merged
GernotMaier merged 25 commits intomainfrom
v492-dev9
Dec 20, 2025
Merged

3-telescope XGB#328
GernotMaier merged 25 commits intomainfrom
v492-dev9

Conversation

@GernotMaier
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings December 15, 2025 19:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the XGBoost direction reconstruction code by extracting training variables into a shared module and adds telescope selection functionality for model application. The key changes include:

  • Extracted training variables into a reusable xgb_training_variables() function
  • Added telescope selection capability with support for bit-coded and comma-separated formats
  • Enhanced the apply_models() function to handle selective event processing
  • Added comprehensive test coverage for the new telescope selection features

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
python/training_variables.py New module defining the xgb_training_variables() function to centralize training variable definitions
python/trainXGBoostforDirection.py Refactored to use xgb_training_variables() from the new module, removing duplicate variable list
python/applyXGBoostforDirection.py Added telescope selection parsing, filtering, and mask-based processing; refactored to use shared training variables
python/tests/test_applyXGBoostforDirection.py New test file with comprehensive coverage for image selection parsing, filtering, and model application
pytest.ini Configuration file to set Python path for pytest
environment.yml Added pytest, pytest-cov, pytest-mock, and shellcheck dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GernotMaier GernotMaier changed the title 3-teleecope XGB 3-telescope XGB Dec 16, 2025
@GernotMaier GernotMaier self-assigned this Dec 16, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GernotMaier GernotMaier merged commit 730c760 into main Dec 20, 2025
7 checks passed
@GernotMaier GernotMaier deleted the v492-dev9 branch December 20, 2025 10:29
@GernotMaier GernotMaier restored the v492-dev9 branch January 10, 2026 15:47
@GernotMaier GernotMaier deleted the v492-dev9 branch January 11, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants