Skip to content

Move all macros into ./macros, as all of them are for VTS#330

Merged
GernotMaier merged 2 commits intomainfrom
v492-dev10-macros
Dec 19, 2025
Merged

Move all macros into ./macros, as all of them are for VTS#330
GernotMaier merged 2 commits intomainfrom
v492-dev10-macros

Conversation

@GernotMaier
Copy link
Copy Markdown
Member

No description provided.

@GernotMaier GernotMaier self-assigned this Dec 19, 2025
Copilot AI review requested due to automatic review settings December 19, 2025 06:51
@GernotMaier GernotMaier merged commit eb2f525 into main Dec 19, 2025
6 of 7 checks passed
@GernotMaier GernotMaier deleted the v492-dev10-macros branch December 19, 2025 06:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves VTS-specific macros from a subdirectory structure into the main ./macros directory, consolidating all macros in a single location. The change includes 15 macro files (C++, Perl, and shell scripts) and updates a reference in the Makefile.

Key Changes

  • Added 15 macro files to the ./macros directory for various VTS analysis tasks (IRF testing, calibration, sensitivity calculations, etc.)
  • Updated the Makefile to reflect the new macro location by removing the macros/VTS/*.C reference
  • Updated one inline comment in plot_flasher_levels.C to reference the new path

Reviewed changes

Copilot reviewed 3 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
macros/test_reducedIRFFiles.C Macro for comparing IRF representations (histograms vs arrays); contains multiple void functions that incorrectly attempt to return 0
macros/sofa_vs_slalib.C Event-by-event comparison between SOFA and SLALIB reconstructions; has uninitialized member variable and copy-paste error in output
macros/print_sensitivity.C Calculates and prints sensitivity from Crab runs
macros/plot_tmva_rejBvsS.C Plots signal vs background efficiency for TMVA output
macros/plot_pedestals.C Compares pedestal values vs run number; has string concatenation issue with integer variable
macros/plot_mscw_variables.C Compares variable distributions from mscw files; contains spelling error in comment
macros/plot_flasher_levels.C Plots flasher levels; updated path reference is incorrect
macros/optimizeBDTcuts.C Optimizes TMVA cuts for gamma/hadron separation
macros/mutate_lped.pl Perl script for processing low-gain pedestal files
macros/make_combined_lped_file.sh Shell script with multiple syntax errors in variable assignments and command flags
macros/getSens.C Plots spectral energy distribution; has variable redeclaration error
macros/calib_combine_lowgainpedestalfiles.C Combines low-gain pedestal files from calibration runs
macros/calcHV.C Calculates high voltage settings for flatfielding
macros/atmosphericSounding.C Plots balloon sounding data compared with CORSIKA/MODTRAN
macros/LowGainCalibrationFromPulsShapeforCare.C Calculates high/low gain multiplier from pulse shapes; has redundant variable initialization
Makefile Removed outdated reference to macros/VTS/*.C
Comments suppressed due to low confidence (1)

macros/plot_flasher_levels.C:7

  • The path reference has been updated but is now incorrect. The macro should reference '$EVNDISPSYS/macros/plot_flasher_levels.C' not '$EVNDISPSYS/VTS/plot_flasher_levels.C' since the file is being moved to ./macros according to the PR description.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants