Skip to content

Remove XGB stuff moved to Eventdisplay-ML#333

Merged
GernotMaier merged 1 commit intomainfrom
move-to-ml
Dec 22, 2025
Merged

Remove XGB stuff moved to Eventdisplay-ML#333
GernotMaier merged 1 commit intomainfrom
move-to-ml

Conversation

@GernotMaier
Copy link
Copy Markdown
Member

@GernotMaier GernotMaier self-assigned this Dec 20, 2025
@GernotMaier GernotMaier marked this pull request as ready for review December 20, 2025 15:49
Copilot AI review requested due to automatic review settings December 20, 2025 15:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes XGBoost-related Python code and dependencies that have been migrated to the separate Eventdisplay-ML repository. The removal includes training and inference scripts, supporting utilities, tests, and the Python environment configuration.

Key changes:

  • Removes XGBoost direction reconstruction training and inference implementations
  • Removes Python-specific environment configuration
  • Removes associated test files

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
py/training_variables.py Removes XGBoost training variable definitions used for direction reconstruction
py/trainXGBoostforDirection.py Removes XGBoost model training script (437 lines) for multi-target direction BDTs
py/applyXGBoostforDirection.py Removes XGBoost model inference script (492 lines) for direction reconstruction
py/tests/test_applyXGBoostforDirection.py Removes unit tests for XGBoost inference functionality
environment.yml Removes conda environment specification with Python 3.13 and ML dependencies

Note: While the code removal is clean, there are references to this XGBoost functionality remaining in the repository that are not addressed in this PR:

  1. docs/changes/322.feature.md documents the XGBoost feature that is now being removed
  2. pytest.ini references a "python" directory that may no longer exist
  3. No documentation update explaining the migration to Eventdisplay-ML or linking to the new repository

These items should be addressed in a follow-up PR or included in this one to maintain documentation consistency.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GernotMaier GernotMaier merged commit 43b9e80 into main Dec 22, 2025
13 checks passed
@GernotMaier GernotMaier deleted the move-to-ml branch December 22, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants