Skip to content

v492-12 Add XGB energy reconstruction#334

Merged
GernotMaier merged 8 commits intomainfrom
v492-12-energy
Dec 23, 2025
Merged

v492-12 Add XGB energy reconstruction#334
GernotMaier merged 8 commits intomainfrom
v492-12-energy

Conversation

@GernotMaier
Copy link
Copy Markdown
Member

No description provided.

@GernotMaier GernotMaier self-assigned this Dec 22, 2025
@GernotMaier GernotMaier marked this pull request as ready for review December 22, 2025 11:23
Copilot AI review requested due to automatic review settings December 22, 2025 11:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds XGBoost (XGB) energy reconstruction capability by introducing a new get_Erec() method to the CData class that can return energy values from different reconstruction methods. The implementation adds support for retrieving energy from a friend tree (Dir_Erec), which enables the XGB reconstruction method alongside existing methods (Erec and ErecS).

Key changes:

  • Added get_Erec() method to CData class with support for multiple energy reconstruction methods
  • Refactored energy access throughout the codebase to use the new method instead of direct member access
  • Added Dir_Erec member variable to store XGB reconstruction results from friend tree

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
inc/CData.h Added Dir_Erec member variable and get_Erec() method declaration
src/CData.cpp Implemented get_Erec() method with 4 different reconstruction method options and initialized Dir_Erec
src/VTMVAEvaluator.cpp Replaced direct ErecS access with get_Erec() calls
src/VStereoAnalysis.cpp Updated tree filling to use get_Erec() instead of direct ErecS access
src/VInstrumentResponseFunctionData.cpp Refactored to use get_Erec() with explicit method parameter
src/VGammaHadronCuts.cpp Simplified getReconstructedEnergy() to delegate to get_Erec()
src/VEffectiveAreaCalculator.cpp Refactored energy reconstruction logic to use get_Erec() with method parameter
src/VDataMCComparision.cpp Extensive replacement of direct ErecS access with get_Erec() calls throughout histogram filling
pytest.ini Removed pytest configuration file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

GernotMaier and others added 5 commits December 22, 2025 12:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@GernotMaier GernotMaier merged commit 472061d into main Dec 23, 2025
7 checks passed
@GernotMaier GernotMaier deleted the v492-12-energy branch December 23, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants