v492-12 Add XGB energy reconstruction#334
Merged
GernotMaier merged 8 commits intomainfrom Dec 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds XGBoost (XGB) energy reconstruction capability by introducing a new get_Erec() method to the CData class that can return energy values from different reconstruction methods. The implementation adds support for retrieving energy from a friend tree (Dir_Erec), which enables the XGB reconstruction method alongside existing methods (Erec and ErecS).
Key changes:
- Added
get_Erec()method toCDataclass with support for multiple energy reconstruction methods - Refactored energy access throughout the codebase to use the new method instead of direct member access
- Added Dir_Erec member variable to store XGB reconstruction results from friend tree
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| inc/CData.h | Added Dir_Erec member variable and get_Erec() method declaration |
| src/CData.cpp | Implemented get_Erec() method with 4 different reconstruction method options and initialized Dir_Erec |
| src/VTMVAEvaluator.cpp | Replaced direct ErecS access with get_Erec() calls |
| src/VStereoAnalysis.cpp | Updated tree filling to use get_Erec() instead of direct ErecS access |
| src/VInstrumentResponseFunctionData.cpp | Refactored to use get_Erec() with explicit method parameter |
| src/VGammaHadronCuts.cpp | Simplified getReconstructedEnergy() to delegate to get_Erec() |
| src/VEffectiveAreaCalculator.cpp | Refactored energy reconstruction logic to use get_Erec() with method parameter |
| src/VDataMCComparision.cpp | Extensive replacement of direct ErecS access with get_Erec() calls throughout histogram filling |
| pytest.ini | Removed pytest configuration file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.