(Re-)introduce energy and direction method selector.

[GernotMaier]

Allow to choose energy and direction reconstruction methods:

Stereo reconstruction
---------------------
Method ids: 0 (DispBDT), 1 (LT Tables), 2 (XGB stereo)
* ENERGYRECONSTRUCTIONMETHOD 0
Method ids:  0 (DispBDT), 1 (Intersection Method), 2 (XGB stereo)
* DIRECTIONRECONSTRUCTIONMETHOD 0

Consistently use CData methods to get variables.

[Copilot]

Pull request overview

This pull request introduces configurable energy and direction reconstruction method selectors, allowing users to choose between three methods for each: DispBDT (0), LT Tables/Intersection Method (1), and XGB stereo (2). The PR also refactors the codebase to consistently use CData methods for retrieving reconstruction variables, removing intermediate helper methods from VGammaHadronCuts.

Changes:

• Adds DIRECTIONRECONSTRUCTIONMETHOD parameter and expands energy reconstruction method support to include XGB stereo (method 2)
• Refactors code to use CData::get_Erec(), get_Xoff(), get_Yoff() methods consistently across the codebase
• Removes intermediate helper methods from VGammaHadronCuts that wrapped CData calls

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/CData.cpp	Updates reconstruction method getters and adds new methods for chi2 and dE
inc/CData.h	Updates method signatures to require method parameter
src/VGammaHadronCuts.cpp	Removes helper methods, uses CData directly, adds stereo method support
inc/VGammaHadronCuts.h	Adds reconstruction method members and updates method signatures
src/VAnaSumRunParameter.cpp	Adds direction method parameter and validation with error messages
inc/VAnaSumRunParameter.h	Adds direction reconstruction method member
src/VInstrumentResponseFunctionRunParameter.cpp	Adds direction method parameter reading
inc/VInstrumentResponseFunctionRunParameter.h	Adds direction reconstruction method member
src/VInstrumentResponseFunction.cpp	Updates to handle both reconstruction methods
inc/VInstrumentResponseFunction.h	Renames method to setStereoReconstructionMethod
src/VInstrumentResponseFunctionData.cpp	Uses direction method for offset calculations
inc/VInstrumentResponseFunctionData.h	Adds direction method setter
src/VEffectiveAreaCalculator.cpp	Removes fIgnoreEnergyReconstruction logic, adds direction method
inc/VEffectiveAreaCalculator.h	Updates fill signature and removes obsolete setter
src/VTMVAEvaluator.cpp	Uses energy reconstruction method for evaluations
inc/VTMVAEvaluator.h	Adds energy method member and updates constructor
src/VStereoAnalysis.cpp	Refactored to use CData methods directly
src/VRadialAcceptance.cpp	Uses direction method for acceptance calculations
inc/VRadialAcceptance.h	Adds direction method member and setter with updated default
src/VDataMCComparision.cpp	Adds method support for histogram filling
inc/VDataMCComparision.h	Adds reconstruction method members
src/makeEffectiveArea.cpp	Passes both methods to fill function
src/makeRadialAcceptance.cpp	Initializes cuts with both methods
src/compareDatawithMC.cpp	Adds method variables and setter calls
inc/VTMVARunDataEnergyCut.h	Adds direction method member and updates ClassDef
docs/changes/339.feature.md	Documents the new feature

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.