Skip to content

Plotting improvements.#50

Merged
GernotMaier merged 4 commits intomainfrom
2025-barcelona
Apr 29, 2025
Merged

Plotting improvements.#50
GernotMaier merged 4 commits intomainfrom
2025-barcelona

Conversation

@GernotMaier
Copy link
Copy Markdown
Member

No description provided.

@GernotMaier GernotMaier self-assigned this Apr 29, 2025
@GernotMaier GernotMaier marked this pull request as ready for review April 29, 2025 16:51
@GernotMaier GernotMaier requested a review from Copilot April 29, 2025 16:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves various plotting functions and updates binary orbit calculations for the light-curve analysis tools. Key changes include:

  • Addition of new plotting routines (distribution, index vs flux, live time vs phase bin)
  • Parameter renaming in the orbit-number calculation for consistency
  • Updated file reading and error reporting in the data reader module

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
v2dl5/scripts/plot_binary_light_curves.py Added calls for new plotting routines to visualize additional metrics
v2dl5/orbital_phase.py Updated get_orbit_number signature and logic with new parameter name
v2dl5/light_curves/data_reader.py Changed ecsv file reading interface and removed redundant try/except
v2dl5/light_curves/binary_plotting.py Several new plotting functions and enhanced logic in subplots
v2dl5/binaries.py Added mjd_orbit_count binary property for improved orbit numbering
eventdisplay_anasum/light_curve_analysis.C Minor updates to parameter handling and logging in the analysis script
Files not reviewed (1)
  • eventdisplay_anasum/light_curve_analysis.sh: Language not supported
Comments suppressed due to low confidence (3)

v2dl5/orbital_phase.py:125

  • The parameter 'mjd_orbit_count' replaces 'mjd_0' for orbit counting; please ensure that all callers and documentation are consistent with this updated name.
def get_orbit_number(mjd, orbital_period, mjd_orbit_count):

v2dl5/light_curves/data_reader.py:137

  • The removal of the try/except block for reading optional columns may cause an unhandled exception if the file is missing expected keys; consider confirming that this change is intended.
def _read_fluxes_from_ecsv_file(self, file_name, time_min_max=True, mjd_min=-1.0, mjd_max=-1.0):

v2dl5/binaries.py:24

  • [nitpick] Only one binary has the 'mjd_orbit_count' property while others fallback to 'mjd_0'; for consistency in orbit number calculations, consider defining 'mjd_orbit_count' for all binaries or documenting the fallback behavior clearly.
"mjd_orbit_count": 52953.0,  # Adams et al 2021

@GernotMaier GernotMaier merged commit 80f1117 into main Apr 29, 2025
3 checks passed
@GernotMaier GernotMaier deleted the 2025-barcelona branch April 29, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants