Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves various plotting functions and updates binary orbit calculations for the light-curve analysis tools. Key changes include:
- Addition of new plotting routines (distribution, index vs flux, live time vs phase bin)
- Parameter renaming in the orbit-number calculation for consistency
- Updated file reading and error reporting in the data reader module
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| v2dl5/scripts/plot_binary_light_curves.py | Added calls for new plotting routines to visualize additional metrics |
| v2dl5/orbital_phase.py | Updated get_orbit_number signature and logic with new parameter name |
| v2dl5/light_curves/data_reader.py | Changed ecsv file reading interface and removed redundant try/except |
| v2dl5/light_curves/binary_plotting.py | Several new plotting functions and enhanced logic in subplots |
| v2dl5/binaries.py | Added mjd_orbit_count binary property for improved orbit numbering |
| eventdisplay_anasum/light_curve_analysis.C | Minor updates to parameter handling and logging in the analysis script |
Files not reviewed (1)
- eventdisplay_anasum/light_curve_analysis.sh: Language not supported
Comments suppressed due to low confidence (3)
v2dl5/orbital_phase.py:125
- The parameter 'mjd_orbit_count' replaces 'mjd_0' for orbit counting; please ensure that all callers and documentation are consistent with this updated name.
def get_orbit_number(mjd, orbital_period, mjd_orbit_count):
v2dl5/light_curves/data_reader.py:137
- The removal of the try/except block for reading optional columns may cause an unhandled exception if the file is missing expected keys; consider confirming that this change is intended.
def _read_fluxes_from_ecsv_file(self, file_name, time_min_max=True, mjd_min=-1.0, mjd_max=-1.0):
v2dl5/binaries.py:24
- [nitpick] Only one binary has the 'mjd_orbit_count' property while others fallback to 'mjd_0'; for consistency in orbit number calculations, consider defining 'mjd_orbit_count' for all binaries or documenting the fallback behavior clearly.
"mjd_orbit_count": 52953.0, # Adams et al 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.