Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds optional y-axis limits to spectral plotting, refactors minor code patterns, and updates configuration examples and documentation for the 0.5.0 dev3 release.
- Introduce
y_min/y_maxparameters inplot_spectraandplot_sedto control y-axis limits. - Refactor
lon/latassignment inget_target, update docstrings and log messages for clarity. - Update example YAML and README to include new
fluxlimits and correct config filename.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| v2dl5/sky_regions.py | Combine lon and lat retrieval into a single tuple assignment. |
| v2dl5/plot.py | Add y_min/y_max to plotting methods, insert placeholder TODO. |
| v2dl5/data.py | Refine docstrings and log messages for region radius handling. |
| v2dl5/analysis.py | Pass new y_min/y_max args from CLI config into plotting call. |
| examples/reflected_region.yml | Add flux: {min, max} block for flux point limits. |
| README.md | Fix example config filename to reflected_region.yml. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.