Skip to content

fix example; print out max wobble distance #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GernotMaier merged 2 commits into from
Jun 2, 2025
Merged

fix example; print out max wobble distance #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9db59a5
fix example; print out max wobble distance
GernotMaier Jun 2, 2025
a4e0cf5
emin
GernotMaier Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/reflected_region.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ datasets:
stack: false
geom:
axes:
energy: {min: 0.1 TeV, max: 100 TeV, nbins: 30}
energy_true: {min: 0.05 TeV, max: 100 TeV, nbins: 40}
energy: {min: 0.1 TeV, max: 100 TeV, nbins: 30}
energy_true: {min: 0.05 TeV, max: 100 TeV, nbins: 40}
exclusion_region:
on_radius: 0.5 deg
magnitude_B: 7
Expand All @@ -43,7 +43,7 @@ flux_points:
flux: {min: 1.e-15, max: 1.e-9}

light_curve:
energy: {min: 1. TeV, max: 100 TeV}
energy: {min: 0.5 TeV, max: 100 TeV}
time_zone: -7
n_jobs: 4
# time_bin_files:
Expand Down
4 changes: 3 additions & 1 deletion v2dl5/sky_regions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ def _read_bright_star_catalogue(self, exclusion_region_dict=None, max_wobble_dis
return _exclusion_regions

self._logger.info(
"Reading bright star catalogue from %s", exclusion_region_dict["star_file"]
f"Reading bright star catalogue from {exclusion_region_dict['star_file']}"
f" (max wobble distance: {max_wobble_distance})"
)
star_file = files("v2dl5.data").joinpath("data/" + exclusion_region_dict["star_file"])
hip = fits.open(star_file)
Expand All @@ -189,6 +190,7 @@ def _read_bright_star_catalogue(self, exclusion_region_dict=None, max_wobble_dis
)

catalogue = catalogue[catalogue["angular_separation"] < u.Quantity(max_wobble_distance)]
catalogue = catalogue[[row is not None for row in catalogue]]

self._logger.info(
"Number of stars in the catalogue passing cuts on magnitude and FOV: %d", len(catalogue)
Expand Down