Skip to content

vV2.2.0 dev - improve testing.#52

Merged
GernotMaier merged 6 commits intomainfrom
v2.2.0-dev
Jun 1, 2025
Merged

vV2.2.0 dev - improve testing.#52
GernotMaier merged 6 commits intomainfrom
v2.2.0-dev

Conversation

@GernotMaier
Copy link
Copy Markdown
Member

Add an additional check before merging and run checkVBF over each file.

@GernotMaier GernotMaier requested a review from Copilot May 31, 2025 12:50
@GernotMaier GernotMaier self-assigned this May 31, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve testing for vV2.2.0 dev by adding an extra check before merging and running checkVBF over each file.

  • Renames the variable from CARE_EXE to MERGE_EXE in the merge submission script.
  • Adjusts the batch size from 250 to 251 and modifies the log file command construction.
  • Updates production configuration values by swapping N_RUNS and N_SHOWER in one file and expanding the NSB_LIST_std range in another.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
scripts/mergevbf.sh Renamed variable for clarity and modified command construction with added check functionality.
config/config_ATM62_Zd65_production.dat Swapped N_RUNS and N_SHOWER values; ensure configuration changes are intentional and documented.
config/config_ATM61_Zd65_production.dat Expanded the NSB_LIST_std values to cover a broader range; ensure clarity on the rationale.
Comments suppressed due to low confidence (1)

scripts/mergevbf.sh:87

  • The log file path construction appears to have an extra set of quotes around ${RUNNUMBER} which may lead to an incorrectly formed file name; please review the quoting to ensure it concatenates as intended.
echo "   ${MERGE_EXE} bash -c \"cd /workdir/EventDisplay_v4 && ${MERGEVBF} && ${ZSTD_VBF}\" > ${MERGEVBF_DATA_DIR}/${MERGEDFILE}"${RUNNUMBER}".log 2>&1

Comment thread config/config_ATM62_Zd65_production.dat
Comment thread config/config_ATM61_Zd65_production.dat
@GernotMaier GernotMaier marked this pull request as ready for review June 1, 2025 15:36
@GernotMaier GernotMaier merged commit 9c1aebf into main Jun 1, 2025
1 check passed
@GernotMaier GernotMaier deleted the v2.2.0-dev branch June 1, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants