Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve testing for vV2.2.0 dev by adding an extra check before merging and running checkVBF over each file.
- Renames the variable from CARE_EXE to MERGE_EXE in the merge submission script.
- Adjusts the batch size from 250 to 251 and modifies the log file command construction.
- Updates production configuration values by swapping N_RUNS and N_SHOWER in one file and expanding the NSB_LIST_std range in another.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/mergevbf.sh | Renamed variable for clarity and modified command construction with added check functionality. |
| config/config_ATM62_Zd65_production.dat | Swapped N_RUNS and N_SHOWER values; ensure configuration changes are intentional and documented. |
| config/config_ATM61_Zd65_production.dat | Expanded the NSB_LIST_std values to cover a broader range; ensure clarity on the rationale. |
Comments suppressed due to low confidence (1)
scripts/mergevbf.sh:87
- The log file path construction appears to have an extra set of quotes around ${RUNNUMBER} which may lead to an incorrectly formed file name; please review the quoting to ensure it concatenates as intended.
echo " ${MERGE_EXE} bash -c \"cd /workdir/EventDisplay_v4 && ${MERGEVBF} && ${ZSTD_VBF}\" > ${MERGEVBF_DATA_DIR}/${MERGEDFILE}"${RUNNUMBER}".log 2>&1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an additional check before merging and run
checkVBFover each file.