Skip to content

Meta-Attribute-Macro Take 2#137

Merged
ryanrdoherty merged 1 commit intomasterfrom
meta-attribute-macro-take2
Mar 11, 2026
Merged

Meta-Attribute-Macro Take 2#137
ryanrdoherty merged 1 commit intomasterfrom
meta-attribute-macro-take2

Conversation

@jbrestel
Copy link
Member

@jbrestel jbrestel commented Mar 7, 2026

Ryan - You did a slight refactor for the META ATTRIBUTES MACRO and slightly broke it. Your version added the primary key columns into the string used for the cross tab function.

Please merge this working copy. if you need to refactor the postgres stuff you can do later

@jbrestel jbrestel requested a review from ryanrdoherty March 7, 2026 03:59
@jbrestel
Copy link
Member Author

jbrestel commented Mar 7, 2026

This was your commit that broke the columns:

9dc8cad

@ryanrdoherty ryanrdoherty merged commit 7c62f24 into master Mar 11, 2026
1 check passed
@ryanrdoherty ryanrdoherty deleted the meta-attribute-macro-take2 branch March 11, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants