add imagemagick hook (unable to complete)#102
Open
Samueru-sama wants to merge 2 commits intoVHSgunzo:mainfrom
Open
add imagemagick hook (unable to complete)#102Samueru-sama wants to merge 2 commits intoVHSgunzo:mainfrom
Samueru-sama wants to merge 2 commits intoVHSgunzo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageMagick is complicated.
It has a ton of config files all over the place in
/usr/share/ImageMagick/usr/lib/ImageMagickand/etc/ImageMagickIt turns out you can put all those files in and a single directory and set
MAGICK_CONFIGURE_PATHto it, tested it working and all fine here.This hook does that operation.
What is not complete is all the env variables that sharun would need to set, It is beyond my rust capabilities:
MAGICK_HOME=$(SHARUN_DIR)When imageMagick is compiled with a portable flag. We also need to set these others for when ImageMagick is not compiled portable:MAGICK_CODER_FILTER_PATH=${SHARUN_DIR}/lib/ImageMagick*/modules*/filtersMAGICK_CODER_MODULE_PATH=${SHARUN_DIR}/lib/ImageMagick*/modules*/codersMAGICK_CONFIGURE_PATH=${SHARUN_DIR}/etc/ImageMagick*See what I'm doing in shell
Yes I actuall went and read the ImageMagick documentation. And was the first person to do so xd