Conversation
a1c916d to
58eb62e
Compare
0c33627 to
6fa5765
Compare
soniacq
left a comment
There was a problem hiding this comment.
Since there are only two possibilities — either including a visualiser or not — using '(0..1)' may be misleading, as it implies a continuous range or multiple values between 0 and 1. Consider replacing it with something more explicit like 'Visualiser (0, 1)' to indicate a binary choice.
|
Enhance the PR description. It doesn't have to be extensive—just a sentence summarizing the changes. |
6fa5765 to
42d7a33
Compare
Allright @soniacq it's ready :) Thanks for this suggestion it was indeed confusing now that you mentioned it 🫡 |
soniacq
left a comment
There was a problem hiding this comment.
Great! Thanks, @simonprovost. Feel free to merge this PR.
Urban Pipelineis quite a substantial component ofUrban Mapper. It therefore deserves attention. We first fix an issue with mermaid and material for mkdocs (plugin related). Then we made sure that the viz. is substantial enough to understand the capabilities of theurban pipeline.Cheers :)
📚 Documentation preview 📚: https://UrbanMapper--58.org.readthedocs.build/en/58/