Interactive Examples Notebooks & Docs Simpleness Improvement#66
Merged
Interactive Examples Notebooks & Docs Simpleness Improvement#66
Conversation
8cc3b33 to
7585b2d
Compare
7585b2d to
7da0da6
Compare
soniacq
requested changes
Jun 25, 2025
Contributor
soniacq
left a comment
There was a problem hiding this comment.
I’ve reviewed this PR and left some comments. Hope they help improve it.
..._of_examples/3-Case-Studies/1-Downtown-BK-Collisions/2-Downtown_BK_Collisions_Pipeline.ipynb
Outdated
Show resolved
Hide resolved
Member
Author
|
@soniacq Thanksss so much for the rapid review; finishing something onto https://github.com/simonprovost/scikit-longitudinal then applying the changes — Hoping tonight otherwise tomorrow 🎉 |
0fd72c2 to
7b9f7bf
Compare
fixup! refactor(examples): prep. notebooks for interactive docs
7b9f7bf to
537fe0d
Compare
Member
Author
|
@soniacq Done and ready on my side :) ! |
Contributor
|
Nice job, @simonprovost! |
Member
Author
|
Thanks so much @soniacq ! Feel free to "accept the PR" (top right I believe) and merge afterwards ? |
soniacq
approved these changes
Jun 27, 2025
Contributor
soniacq
left a comment
There was a problem hiding this comment.
All comments were well addressed. Thanks, @simonprovost.
This was referenced Jun 27, 2025
This was referenced Jun 30, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks!
The following PR is about:
To viz. the changes click in the generated ReadTheDocs links below!
📚 Documentation preview 📚: https://UrbanMapper--66.org.readthedocs.build/en/66/