Skip to content

Interactive Examples Notebooks & Docs Simpleness Improvement#66

Merged
soniacq merged 9 commits intomainfrom
feat/interactive_examples_and_docs_simplification
Jun 27, 2025
Merged

Interactive Examples Notebooks & Docs Simpleness Improvement#66
soniacq merged 9 commits intomainfrom
feat/interactive_examples_and_docs_simplification

Conversation

@simonprovost
Copy link
Member

@simonprovost simonprovost commented Jun 24, 2025

Hey folks!

The following PR is about:

To viz. the changes click in the generated ReadTheDocs links below!


📚 Documentation preview 📚: https://UrbanMapper--66.org.readthedocs.build/en/66/

@simonprovost simonprovost self-assigned this Jun 24, 2025
@simonprovost simonprovost added the documentation Improvements or additions to documentation label Jun 24, 2025
@simonprovost simonprovost force-pushed the feat/interactive_examples_and_docs_simplification branch 3 times, most recently from 8cc3b33 to 7585b2d Compare June 24, 2025 19:09
@simonprovost simonprovost force-pushed the feat/interactive_examples_and_docs_simplification branch from 7585b2d to 7da0da6 Compare June 24, 2025 19:36
@simonprovost simonprovost requested a review from soniacq June 24, 2025 19:52
Copy link
Contributor

@soniacq soniacq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed this PR and left some comments. Hope they help improve it.

@simonprovost
Copy link
Member Author

@soniacq Thanksss so much for the rapid review; finishing something onto https://github.com/simonprovost/scikit-longitudinal then applying the changes — Hoping tonight otherwise tomorrow 🎉

@simonprovost simonprovost force-pushed the feat/interactive_examples_and_docs_simplification branch 3 times, most recently from 0fd72c2 to 7b9f7bf Compare June 27, 2025 09:08
@simonprovost simonprovost force-pushed the feat/interactive_examples_and_docs_simplification branch from 7b9f7bf to 537fe0d Compare June 27, 2025 09:18
@simonprovost
Copy link
Member Author

@soniacq Done and ready on my side :) !

@soniacq
Copy link
Contributor

soniacq commented Jun 27, 2025

Nice job, @simonprovost!
This PR is now ready to be merged into the master branch.

@soniacq soniacq self-requested a review June 27, 2025 14:02
@simonprovost
Copy link
Member Author

Thanks so much @soniacq ! Feel free to "accept the PR" (top right I believe) and merge afterwards ?

Copy link
Contributor

@soniacq soniacq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments were well addressed. Thanks, @simonprovost.

@soniacq soniacq merged commit 04f955b into main Jun 27, 2025
8 checks passed
@simonprovost simonprovost deleted the feat/interactive_examples_and_docs_simplification branch July 8, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants