Support Gray-Mode + Github Issues Modernisation#78
Conversation
|
Friendly up reminder, @soniacq or @fabiofelix 🙏 |
soniacq
left a comment
There was a problem hiding this comment.
Great update!
Dark/light mode support and modernized YAML issue templates improve UX and contributor experience. Two minor notes: there’s an official logo for dark backgrounds (also used on the official OSCUR website) that we may want to use instead of the gray one you created—I’m attaching it here.
Also, which logo is shown by default, light or dark background? I think light would be better. Otherwise, ready to merge.

a5ad221 to
f6e0f42
Compare
Brills! Thanks for taking the time to focus this PR @soniacq 🙏 All modified, and fixed-up :)!
Cheers |
soniacq
left a comment
There was a problem hiding this comment.
Please address the issue regarding the logo selection based on the background. Thanks!
f6e0f42 to
afaa989
Compare
All good now and rebased with Cheers |
d94f1a5 to
afaa989
Compare
afaa989 to
65dce0f
Compare
soniacq
left a comment
There was a problem hiding this comment.
Thank @simonprovost, for addressing all the requested changes. Ready to merge.
65dce0f to
47ceb93
Compare
Brills! Thanks Sonia! Just rebased with main and pushed |
@simonprovost Tests / test (3.12) is failing. Any idea what could be causing this? Thank you! |
Re running in debug-mode now... strange right! |
|
@soniacq I am suspecting a change on OSM’s side (I’m bedazzled though if it’s true); so I’ve de-emphasized the distance strictness in the tests that were failing when querying OSM. While I don’t like being out of scope, let’s consider this a hotfix in the current PR — all good? Hoping it goes through; locally it did |
Hi @soniacq,
Hope all is well :) here is a quick docs-oriented PR to (1) support light and dark mode for the ReadME, as well as (2) modernise our GitHub issues templates to be more 2025-kind of templates!
Hope that's all fine, let me know.
Here is a quick video to recap it all visually speaking
PRVideoCompressed.mp4
📚 Documentation preview 📚: https://UrbanMapper--78.org.readthedocs.build/en/78/