Skip to content

Support Gray-Mode + Github Issues Modernisation#78

Merged
soniacq merged 4 commits intomainfrom
refactor/best_practices_docs
Oct 30, 2025
Merged

Support Gray-Mode + Github Issues Modernisation#78
soniacq merged 4 commits intomainfrom
refactor/best_practices_docs

Conversation

@simonprovost
Copy link
Member

@simonprovost simonprovost commented Sep 17, 2025

Hi @soniacq,

Hope all is well :) here is a quick docs-oriented PR to (1) support light and dark mode for the ReadME, as well as (2) modernise our GitHub issues templates to be more 2025-kind of templates!

Hope that's all fine, let me know.

Here is a quick video to recap it all visually speaking

PRVideoCompressed.mp4

📚 Documentation preview 📚: https://UrbanMapper--78.org.readthedocs.build/en/78/

@simonprovost simonprovost self-assigned this Sep 17, 2025
@simonprovost simonprovost added the documentation Improvements or additions to documentation label Sep 17, 2025
@simonprovost
Copy link
Member Author

Friendly up reminder, @soniacq or @fabiofelix 🙏

Copy link
Contributor

@soniacq soniacq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update!
Dark/light mode support and modernized YAML issue templates improve UX and contributor experience. Two minor notes: there’s an official logo for dark backgrounds (also used on the official OSCUR website) that we may want to use instead of the gray one you created—I’m attaching it here.

Also, which logo is shown by default, light or dark background? I think light would be better. Otherwise, ready to merge.
oscur-logo-white

@simonprovost simonprovost force-pushed the refactor/best_practices_docs branch from a5ad221 to f6e0f42 Compare September 26, 2025 18:49
@simonprovost
Copy link
Member Author

Great update! Dark/light mode support and modernized YAML issue templates improve UX and contributor experience. Two minor notes: there’s an official logo for dark backgrounds (also used on the official OSCUR website) that we may want to use instead of the gray one you created—I’m attaching it here.

Also, which logo is shown by default, light or dark background? I think light would be better. Otherwise, ready to merge.

Brills! Thanks for taking the time to focus this PR @soniacq 🙏 All modified, and fixed-up :)!

  • New dark-mode logo is the official one (my bad btw!)
  • Default is always light-mode logo

Cheers

Copy link
Contributor

@soniacq soniacq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the issue regarding the logo selection based on the background. Thanks!

@simonprovost simonprovost force-pushed the refactor/best_practices_docs branch from f6e0f42 to afaa989 Compare September 27, 2025 09:06
@simonprovost
Copy link
Member Author

Please address the issue regarding the logo selection based on the background. Thanks!

All good now and rebased with main following recent merge 🥳

Cheers

@simonprovost simonprovost force-pushed the refactor/best_practices_docs branch from d94f1a5 to afaa989 Compare September 29, 2025 22:15
@simonprovost simonprovost force-pushed the refactor/best_practices_docs branch from afaa989 to 65dce0f Compare October 29, 2025 20:18
@simonprovost simonprovost changed the title Support Dark & Light Mode + Github Issues Modernisation Support Gray-Mode + Github Issues Modernisation Oct 29, 2025
Copy link
Contributor

@soniacq soniacq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @simonprovost, for addressing all the requested changes. Ready to merge.

@simonprovost simonprovost force-pushed the refactor/best_practices_docs branch from 65dce0f to 47ceb93 Compare October 30, 2025 14:11
@simonprovost
Copy link
Member Author

Thank @simonprovost, for addressing all the requested changes. Ready to merge.

Brills! Thanks Sonia! Just rebased with main and pushed

@soniacq
Copy link
Contributor

soniacq commented Oct 30, 2025

Thank @simonprovost, for addressing all the requested changes. Ready to merge.

Brills! Thanks Sonia! Just rebased with main and pushed

@simonprovost Tests / test (3.12) is failing. Any idea what could be causing this?
@fabiofelix any thoughts?

Thank you!

@simonprovost
Copy link
Member Author

Thank @simonprovost, for addressing all the requested changes. Ready to merge.

Brills! Thanks Sonia! Just rebased with main and pushed

@simonprovost Tests / test (3.12) is failing. Any idea what could be causing this? @fabiofelix any thoughts?

Thank you!

Re running in debug-mode now... strange right!

@simonprovost
Copy link
Member Author

@soniacq I am suspecting a change on OSM’s side (I’m bedazzled though if it’s true); so I’ve de-emphasized the distance strictness in the tests that were failing when querying OSM. While I don’t like being out of scope, let’s consider this a hotfix in the current PR — all good?

Hoping it goes through; locally it did

@soniacq soniacq merged commit 96afb36 into main Oct 30, 2025
11 checks passed
@soniacq soniacq deleted the refactor/best_practices_docs branch October 30, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants