Merged
Conversation
simonprovost
force-pushed
the
fix/with_column_enforcing
branch
from
23e0f1e to
d5d4033
Compare
Member
Author
|
Ready @fabiofelix |
fabiofelix
approved these changes
Nov 12, 2025
Contributor
There was a problem hiding this comment.
Hey @simonprovost, everything seems okay! If you don't have anything else to change, we can merge this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @fabiofelix !
Hope all is well. I managed to solve finally #44 ! I believe, given your recent great additions of multi-loaders and enrichers, we here simply needed to enforce so that no multi-with-columns is being instantiated to avoid confusion with users.
Let me know if you want me to make any changes!
If you want to see the changes of this PR only for the time begin: click here
Solving #44 !
Warning
Please wait for #82 to be merged prior merging this one! I'll just have to quickly rebase with
mainto be up to date and good!Cheeers
📚 Documentation preview 📚: https://UrbanMapper--83.org.readthedocs.build/en/83/