Add support for newer cmake versions (and their policies)#894
Add support for newer cmake versions (and their policies)#894leonardocarreras wants to merge 2 commits intoVILLASframework:masterfrom
Conversation
1686a8b to
e49064b
Compare
|
The CI is not fully working (does not pull the images for the tests, for example for mosquitto) |
|
Hey @n-eiling, do you want to review this change as well? Are you still working with VILLASnode? Or do you want to be removed from the CODEOWNERS file for future PRs? |
180ea6b to
e49064b
Compare
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
e49064b to
8ad1ad9
Compare
|
Hey @leonardocarreras, lets wait until the end of the week and otherwise merge it :) |
|
I don't think the GPU code is working right now. As far as I know, nobody has used it in a long time. I wouldn't be opposed to removing it. |
|
@n-eiling thanks for the feedback, it is still giving some errors even with this... If removing is also a reasonable option then is a good future step, |
|
Do we then rip-out all the GPU related stuff? |
|
It's not that deeply integrates, or is it? If it's not too much trouble, I think removing it is a good idea. |
|
I can attempt a PR to remove the GPU stuff this week. I assume if it works, in that case this PR will not be needed... |
|
Closing now, not needed due to #908 |
This PR adds:
This gives some errors related to CMP0146 and CMP0104 in newer CMake versions
This is needed in sogno-platform/dpsim#334 (was tested locally)