Skip to content

Add support for newer cmake versions (and their policies)#894

Closed
leonardocarreras wants to merge 2 commits intoVILLASframework:masterfrom
leonardocarreras:add-cuda-policies
Closed

Add support for newer cmake versions (and their policies)#894
leonardocarreras wants to merge 2 commits intoVILLASframework:masterfrom
leonardocarreras:add-cuda-policies

Conversation

@leonardocarreras
Copy link
Copy Markdown
Contributor

This PR adds:

  • A check for CUDA language availability in CMakeLists of the main villlas-node
  • Changes the hardcoding of a path in for villas-fpga (in gpu)

This gives some errors related to CMP0146 and CMP0104 in newer CMake versions

This is needed in sogno-platform/dpsim#334 (was tested locally)

@leonardocarreras
Copy link
Copy Markdown
Contributor Author

The CI is not fully working (does not pull the images for the tests, for example for mosquitto)

@leonardocarreras leonardocarreras marked this pull request as draft April 27, 2025 18:28
stv0g
stv0g previously approved these changes Apr 28, 2025
@stv0g
Copy link
Copy Markdown
Contributor

stv0g commented Apr 28, 2025

Hey @n-eiling,

do you want to review this change as well? Are you still working with VILLASnode? Or do you want to be removed from the CODEOWNERS file for future PRs?

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
@stv0g stv0g force-pushed the add-cuda-policies branch from e49064b to 8ad1ad9 Compare April 29, 2025 07:13
@stv0g stv0g marked this pull request as ready for review April 29, 2025 07:13
@stv0g
Copy link
Copy Markdown
Contributor

stv0g commented Apr 29, 2025

Hey @leonardocarreras,

lets wait until the end of the week and otherwise merge it :)

@n-eiling
Copy link
Copy Markdown
Member

n-eiling commented May 2, 2025

I don't think the GPU code is working right now. As far as I know, nobody has used it in a long time. I wouldn't be opposed to removing it.

@leonardocarreras
Copy link
Copy Markdown
Contributor Author

@n-eiling thanks for the feedback, it is still giving some errors even with this... If removing is also a reasonable option then is a good future step, gdrcopy also brings problems

@stv0g
Copy link
Copy Markdown
Contributor

stv0g commented May 3, 2025

Do we then rip-out all the GPU related stuff?

@n-eiling
Copy link
Copy Markdown
Member

n-eiling commented May 3, 2025

It's not that deeply integrates, or is it? If it's not too much trouble, I think removing it is a good idea.

@leonardocarreras
Copy link
Copy Markdown
Contributor Author

I can attempt a PR to remove the GPU stuff this week. I assume if it works, in that case this PR will not be needed...

@leonardocarreras
Copy link
Copy Markdown
Contributor Author

Closing now, not needed due to #908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants