Skip to content

feat(Carousel): add component Carousel with scroll-snaps support#9393

Closed
EldarMuhamethanov wants to merge 2 commits intomasterfrom
e.muhamethanov/carousel-with-scroll-snaps
Closed

feat(Carousel): add component Carousel with scroll-snaps support#9393
EldarMuhamethanov wants to merge 2 commits intomasterfrom
e.muhamethanov/carousel-with-scroll-snaps

Conversation

@EldarMuhamethanov
Copy link
Copy Markdown
Contributor

  • close #

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Компонент Carousel с поддержкой scroll-snap

Release notes

@EldarMuhamethanov EldarMuhamethanov self-assigned this Jan 23, 2026
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner January 23, 2026 17:20
@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft January 23, 2026 17:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2026

size-limit report 📦

Path Size
JS 411.3 KB (0%)
JS (gzip) 126.21 KB (0%)
JS (brotli) 104.32 KB (0%)
JS import Div (tree shaking) 811 B (0%)
CSS 373.28 KB (0%)
CSS (gzip) 46.25 KB (0%)
CSS (brotli) 36.58 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2026

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit 883ff2d

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9393/883ff2da54bd3dfcd9820c5697ec9aff4ceb69f6/pkg/@vkontakte/vkui/_pkg.tgz

Commit 883ff2d

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 0% with 471 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.12%. Comparing base (8dfd899) to head (883ff2d).
⚠️ Report is 59 commits behind head on master.

Files with missing lines Patch % Lines
...src/components/Carousel/helpers/useCarouselDrag.ts 0.00% 90 Missing ⚠️
...ages/vkui/src/components/Carousel/CarouselBase.tsx 0.00% 57 Missing ⚠️
...rc/components/Carousel/helpers/useScrollToSlide.ts 0.00% 54 Missing ⚠️
...i/src/components/Carousel/helpers/scrollToSlide.ts 0.00% 43 Missing ⚠️
.../src/components/Carousel/helpers/useActiveSlide.ts 0.00% 37 Missing ⚠️
packages/vkui/src/components/Carousel/Carousel.tsx 0.00% 31 Missing ⚠️
.../vkui/src/components/Carousel/CarouselViewPort.tsx 0.00% 27 Missing ⚠️
...omponents/Carousel/helpers/calculateActiveSlide.ts 0.00% 24 Missing ⚠️
...rc/components/Carousel/helpers/useControlsState.ts 0.00% 24 Missing ⚠️
.../components/Carousel/helpers/useSlideNavigation.ts 0.00% 21 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9393      +/-   ##
==========================================
- Coverage   94.73%   91.12%   -3.61%     
==========================================
  Files         440      456      +16     
  Lines       11898    12369     +471     
  Branches     4386     4523     +137     
==========================================
  Hits        11271    11271              
- Misses        627     1098     +471     
Flag Coverage Δ
unittests 91.12% <0.00%> (-3.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Feb 2, 2026
@EldarMuhamethanov
Copy link
Copy Markdown
Contributor Author

Решили, что пока переход на scroll-snaps будет, сильно ломающим обратную совместимость, изменением

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants