feat(Carousel): add component Carousel with scroll-snaps support#9393
Closed
EldarMuhamethanov wants to merge 2 commits intomasterfrom
Closed
feat(Carousel): add component Carousel with scroll-snaps support#9393EldarMuhamethanov wants to merge 2 commits intomasterfrom
EldarMuhamethanov wants to merge 2 commits intomasterfrom
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9393/883ff2da54bd3dfcd9820c5697ec9aff4ceb69f6/pkg/@vkontakte/vkui/_pkg.tgzCommit 883ff2d |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9393 +/- ##
==========================================
- Coverage 94.73% 91.12% -3.61%
==========================================
Files 440 456 +16
Lines 11898 12369 +471
Branches 4386 4523 +137
==========================================
Hits 11271 11271
- Misses 627 1098 +471
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Решили, что пока переход на scroll-snaps будет, сильно ломающим обратную совместимость, изменением |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Компонент Carousel с поддержкой scroll-snap
Release notes