[k2] refactor pcre2 functions #1501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atched_as_null> dump_matches
apolyakov
reviewed
Dec 29, 2025
| #include <optional> | ||
| #include <string_view> | ||
|
|
||
| #include "runtime-light/stdlib/diagnostics/logs.h" |
Contributor
There was a problem hiding this comment.
Please, remove unused includes and add ones you actually use
| } | ||
|
|
||
| private: | ||
| const PCRE2_UCHAR8* m_ptr; |
Contributor
There was a problem hiding this comment.
nit: let's move all member declarations to the a type declaration's beginning
Shamzik
force-pushed
the
kshamazov/pcre2_functions
branch
3 times, most recently
from
a0b27ae to
5082d72
Compare
Shamzik
force-pushed
the
kshamazov/pcre2_functions
branch
from
5082d72 to
b7c8ac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm adding pcre2-functions.h and pcre2-functions.cpp, into which I've extracted all PCRE2 specifics.