api: fix pointsCache stale reads and table multi-LOD column corruption - #2280
Merged
Merged
Conversation
pointsCache stored a single loadedAtNano per cache entry, shared across all time ranges of the same query. Loading one range refreshed that timestamp, so an already-invalidated range could be revalidated and served stale. Track loadedAtNano per time range instead. getTableFromLODs ran the "pad missing rows with NaN" step inside the per-LOD loop. Since each (time, tags) row belongs to exactly one LOD, a row from an earlier LOD got an extra NaN appended for every subsequent LOD, misaligning Data column counts. Pad once per handler-what, after all LODs. Both paths get a regression test.
Rustamchuk
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pointsCache stored a single loadedAtNano per cache entry, shared across all time ranges of the same query. Loading one range refreshed that timestamp, so an already-invalidated range could be revalidated and served stale. Track loadedAtNano per time range instead.
getTableFromLODs ran the "pad missing rows with NaN" step inside the per-LOD loop. Since each (time, tags) row belongs to exactly one LOD, a row from an earlier LOD got an extra NaN appended for every subsequent LOD, misaligning Data column counts. Pad once per handler-what, after all LODs.
Both paths get a regression test.