Skip to content

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Feb 16, 2025

内容

#1006 の副産物。deny.tomlのこの部分をテストする。

voicevox_core/deny.toml

Lines 2 to 14 in 60790a1

targets = [
{ triple = "x86_64-pc-windows-msvc" },
{ triple = "i686-pc-windows-msvc" },
{ triple = "x86_64-unknown-linux-gnu" },
{ triple = "aarch64-unknown-linux-gnu" },
{ triple = "aarch64-linux-android" },
{ triple = "x86_64-linux-android" },
{ triple = "aarch64-apple-darwin" },
{ triple = "x86_64-apple-darwin" },
{ triple = "aarch64-apple-ios" },
{ triple = "aarch64-apple-ios-sim" },
{ triple = "x86_64-apple-ios" },
]

See-also: rust-lang/rust#125579
See-also: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/--print.20host.5B-tuple.7C-triple.5D/near/452327295

関連 Issue

その他

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マージは0.16のあとで!

@Hiroshiba Hiroshiba requested a review from Copilot March 8, 2025 19:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds a new GitHub Actions workflow that checks if the release target tuples defined in deny.toml match the configuration in the build_and_deploy workflow.

  • Introduces a workflow file to validate consistency between deny.toml and build_and_deploy.yml.
  • Downloads and installs a specific version of go-yq v4 for processing YAML files.
  • Uses shell commands to extract and compare target tuples between the two configuration files.

Reviewed Changes

File Description
.github/workflows/check-release-target-tuples.yml New workflow to check that the release target tuples across configurations are consistent.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/check-release-target-tuples.yml:22

  • The script does not handle the scenario where no valid tag is found. Consider adding a check to ensure that 'tag' is non-empty before attempting to download.
tag=$(
            gh release ls -R mikefarah/yq --json tagName,isPrerelease \

.github/workflows/check-release-target-tuples.yml:37

  • [nitpick] The extraction of 'targets' relies on a specific YAML structure in build_and_deploy.yml. It might be beneficial to add documentation or a safeguard to ensure the structure remains consistent.
targets=$(yq -ro json '.jobs.config.steps[] | select(.id == "strategy_matrix").run' ./.github/workflows/build_and_deploy.yml)

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

0.16に入れて良さそう!!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@qryxip qryxip merged commit cc84dde into VOICEVOX:main Mar 13, 2025
@qryxip qryxip deleted the pr/ci-check-release-target-tuples-workflow branch March 13, 2025 17:41
qryxip added a commit to qryxip/voicevox_core that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants