-
Notifications
You must be signed in to change notification settings - Fork 128
ci: Check release target tuples
ワークフローを追加
#1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Check release target tuples
ワークフローを追加
#1012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
マージは0.16のあとで!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR adds a new GitHub Actions workflow that checks if the release target tuples defined in deny.toml match the configuration in the build_and_deploy workflow.
- Introduces a workflow file to validate consistency between deny.toml and build_and_deploy.yml.
- Downloads and installs a specific version of go-yq v4 for processing YAML files.
- Uses shell commands to extract and compare target tuples between the two configuration files.
Reviewed Changes
File | Description |
---|---|
.github/workflows/check-release-target-tuples.yml | New workflow to check that the release target tuples across configurations are consistent. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/check-release-target-tuples.yml:22
- The script does not handle the scenario where no valid tag is found. Consider adding a check to ensure that 'tag' is non-empty before attempting to download.
tag=$(
gh release ls -R mikefarah/yq --json tagName,isPrerelease \
.github/workflows/check-release-target-tuples.yml:37
- [nitpick] The extraction of 'targets' relies on a specific YAML structure in build_and_deploy.yml. It might be beneficial to add documentation or a safeguard to ensure the structure remains consistent.
targets=$(yq -ro json '.jobs.config.steps[] | select(.id == "strategy_matrix").run' ./.github/workflows/build_and_deploy.yml)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
0.16に入れて良さそう!!
Refs: VOICEVOX#1012 (comment) Co-authored-by: Hiroshiba <[email protected]>
This reverts commit f07c025.
This reverts commit 71a4455.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
内容
#1006 の副産物。deny.tomlのこの部分をテストする。
voicevox_core/deny.toml
Lines 2 to 14 in 60790a1
See-also: rust-lang/rust#125579
See-also: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/--print.20host.5B-tuple.7C-triple.5D/near/452327295
関連 Issue
その他