-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Support resize and vertical resize command #9726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Just cloned your fork and checkout to the branch to run the tests. Is this just WIP or do you get different errors? |
Sorry, I might not have noticed it at the time. Let me quickly fix this issue |
…tatus messages for invalid commands and arguments
done |
The tests are passing now, thanks. I tried the command a bit and it feels smooth and how I imagine it should work in vim (never really used the vertical command in vim personally, always relied on ctrl+w). I am not a maintainer sadly so I can't approve but I like your implementation. |
LGTM Co-authored-by: AzimovParviz <[email protected]>
I tested it and it actually fails to parse it as a valid command as far as I can tell at a glance @J-Fields apologies for pinging, would a command like 'vertical-resize' with a dash in it be supported by the current exCommandParser? I tried playing around with the grep command and with different variations like Same with the vertical-resize command. Should something be done about exCommandParser or should each command implementation deal with that by itself? |
What this PR does / why we need it:
I personally prefer using the vert resize and resize commands for adjusting window size. Since I noticed these commands aren’t currently supported, I went ahead and implemented them
Which issue(s) this PR fixes
#9725
This may also partially address
#9227
Special notes for your reviewer:
I’ve only implemented the commonly used parts of these two commands.
For the :resize command, I couldn’t find any built-in VS Code function that achieves an effect similar to workbench.action.toggleEditorWidths in the vertical direction, nor one that sets the editor height to a specific number of lines (e.g., :resize 20).
It’s possible my understanding of VS Code is incomplete, so if you know of a similar command, please let me know and I’ll be happy to update this PR accordingly.