Allow pasting registers from QuickPick menu #9730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGessinger
commented
Aug 19, 2025
| } | ||
|
|
||
| private static async paste(vimState: VimState, item: RegisterDisplayItem) { | ||
| // TODO: Can I reuse PutCommand here? |
There was a problem hiding this comment.
This paste method feels wrong. I don't want to have to reinvent the wheel just to actually paste register content. I would like to reuse existing functionality, but I couldn't figure out the correct way to do that.
What I tried was to create an instance of PutCommand here and pass it the register key as part of its arguments, but somehow that didn't give me the desired result (I had to press ESC after clicking the paste button, for the text to show up).
Perhaps someone can give me some pointers for how to implement this properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds extends the
:displaycommand, so that the QuickPick which opens to show the registers also offers action buttons to paste the register content. This is equivalent to running:di, followed by:putwith the selected register. While the functionality is not new per se, it makes the QuickPick of the registers slightly more useful.In order to do this, most of the changes are within
registers.tsbut some small changes were made to theRegisterclass as well. These are convenience functions, and they do not alter any existing functionality.Which issue(s) this PR fixes
I couldn't find an issue which talks about this feature. If a linked issue is required, I can open one afterwards and discussion can happen there, but at least for me this feature would improve my productivity greatly.
Special notes for your reviewer:
I know it's a mouse action rather than a keyboard action. The Vim gods shall have mercy on my soul.