Skip to content

Commit 66f8290

Browse files
authored
Merge pull request #21 from Vacasa/TNR-1804-change-backoff-to-retry
TNR-1804: Switched backoff to retry for gunicorn compatibility
2 parents 91d1952 + 7621227 commit 66f8290

File tree

4 files changed

+27
-12
lines changed

4 files changed

+27
-12
lines changed

Pipfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ backoff = "*"
88
pendulum = "*"
99
requests = "*"
1010
pytest = "*"
11+
retry = "*"
1112

1213
[requires]
1314
python_version = "3.6"

Pipfile.lock

Lines changed: 22 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
license='MIT',
1010
install_requires=[
1111
'pendulum==2.*',
12-
'backoff~=1.6',
13-
'requests>=2.20.0'
12+
'requests>=2.20.0',
13+
'retry==0.9.*'
1414
],
1515
long_description=open('README.md').read()
1616
)

vacasa/connect/connect.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
from typing import Optional
55
from urllib.parse import urlparse, urlunparse
66

7-
import backoff
87
import pendulum
98
import requests
9+
from retry import retry
1010

1111

1212
def is_https_url(url: str) -> bool:
@@ -130,8 +130,7 @@ def _generate_signature(self, timestamp: int) -> str:
130130
return hmac.new(secret, message, hashlib.sha256).hexdigest()
131131

132132
@staticmethod
133-
@backoff.on_exception(backoff.fibo,
134-
requests.exceptions.RequestException, max_tries=5)
133+
@retry(exceptions=requests.exceptions.RequestException, tries=5, delay=1, backoff=2)
135134
def _get(url, headers: dict = None, params: dict = None):
136135
"""HTTP GET request helper."""
137136
if headers is None:

0 commit comments

Comments
 (0)