Add basic GUI based on Zenity #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This script should probably re-spawn itself as root, because it could not kill windows2usb script and its spawned processes, as they were running as root. |
ValdikSS
reviewed
Sep 7, 2019
|
|
||
| while [[ -z "$image" ]] | ||
| do | ||
| image="$(zenity --file-selection --title='Select image')" |
Owner
There was a problem hiding this comment.
Suggested change
| image="$(zenity --file-selection --title='Select image')" | |
| image="$(zenity --file-selection --file-filter='Image files (iso) | *.iso *.ISO' --file-filter='All files | *' --title='Select image')" |
| --title='Select bootloader mode' \ | ||
| --column='' --column='ID' --column='Mode' --hide-column=2 \ | ||
| FALSE 'mbr' 'BIOS Boot' \ | ||
| TRUE 'gpt' 'UEFI Boot' \ |
Owner
There was a problem hiding this comment.
Suggested change
| TRUE 'gpt' 'UEFI Boot' \ | |
| TRUE 'gpt' 'UEFI Boot (recommended)' \ |
Owner
|
And it would be much, much better to actually show the progress. Is it possible to parse 7z progress in percentage and show it in zenity progress bar? |
Owner
|
@shvchk ping |
Owner
|
@shvchk ping. I really want to merge that but it doesn't work correctly as for now. |
|
Hey could you merge this? Its been half a decade lol |
Nvm this is probably going to break stuff
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6