Add timeout support for JavaScript evaluation #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional timeout parameter to eval/2 and eval/3 that interrupts
long-running JavaScript code. Uses QuickJS interrupt handler with
monotonic clock to detect when deadline is exceeded.
- Add deadline_ms field to JsContext struct
- Implement interrupt handler that checks deadline on each tick
- Update nif_eval to accept timeout_ms parameter (0 = no timeout)
- Update nif_run for callbacks with timeout support
- Return {:error, :timeout} when execution exceeds deadline
- Ensure deadline resets between calls for context reuse
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional timeout parameter to eval/2 and eval/3 that interrupts long-running JavaScript code.