Fix modTemperature NaN/Inf handling#10
Merged
ThePlasticPotato merged 1 commit intoValkyrienSkies:1.20.x/mainfrom Dec 10, 2025
Merged
Fix modTemperature NaN/Inf handling#10ThePlasticPotato merged 1 commit intoValkyrienSkies:1.20.x/mainfrom
ThePlasticPotato merged 1 commit intoValkyrienSkies:1.20.x/mainfrom
Conversation
ThePlasticPotato
merged commit b29428a
into
ValkyrienSkies:1.20.x/main
2 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NaN and Inf are treated as the max value in
max, meaning they get propagated through the system.Why nodes sometimes end up with NaN temperature in the first place, I have no idea, but fixing the check is probably an alright first step.