VSU: fix modmask triggering for every channel#148
Open
skyfloogle wants to merge 1 commit intoValleyBell:masterfrom
Open
VSU: fix modmask triggering for every channel#148skyfloogle wants to merge 1 commit intoValleyBell:masterfrom
skyfloogle wants to merge 1 commit intoValleyBell:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug I introduced in #142. I implemented a hardware bug where writing to S5FQL or S5FQH locks the corresponding byte of the frequency value. In my initial implementation, however, this triggered when writing the FQL or FQH registers of any channel, not just channel 5.
Reproducing sample with before/after/hardware (may not be pleasant to listen to):
repro.zip