Skip to content

Conversation

@sinjs
Copy link
Collaborator

@sinjs sinjs commented Jul 5, 2025

No description provided.

Copy link
Member

@WolverinDEV WolverinDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey ho,
thanks for your PR — looks great! :)

The comments I left in the code are mostly minor things, just some nitpicks here and there.
As for functionality, I'm currently having issues with KDMapper crashing my PC, so I'll just manually map the driver later to test the rest.

One thing I noticed during mapping:
The Nal fix appears to require a manual "Enter" key press before completing. Without it, the execution hangs indefinitely.

I haven’t tested the launch or update mechanisms yet. I’ll check those out later.

@sinjs
Copy link
Collaborator Author

sinjs commented Jul 5, 2025

I'll implement these suggestions tomorrow, thanks for reviewing.

@sinjs sinjs marked this pull request as ready for review July 6, 2025 15:37
@sinjs sinjs requested a review from WolverinDEV July 6, 2025 15:37
@sinjs sinjs merged commit 58494eb into master Jul 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants