backend: Add support for deferred backends#2004
Merged
Conversation
So we can eg. init Gamescope headlessly then transition into a backend that only uses SAMPLED modifiers like SteamVR. This way we can init VRWebHelper in a Gamescope before SteamVR fully comes up.
7024476 to
8f82d51
Compare
|
I'm getting segfault using DRM backend on virtio-gpu caused by change made in this PR: This fixes the crash: diff --git a/src/Backends/DRMBackend.cpp b/src/Backends/DRMBackend.cpp
index 813573c..0005eb8 100644
--- a/src/Backends/DRMBackend.cpp
+++ b/src/Backends/DRMBackend.cpp
@@ -2558,7 +2558,7 @@ drm_prepare_liftoff( struct drm_t *drm, const struct FrameInfo_t *frameInfo, boo
if ( i < frameInfo->layerCount )
{
const FrameInfo_t::Layer_t *pLayer = &frameInfo->layers[ i ];
- gamescope::CDRMFb *pDrmFb = static_cast<gamescope::CDRMFb *>( pLayer->tex ? pLayer->tex->GetBackendFb()->Unwrap() : nullptr );
+ gamescope::CDRMFb *pDrmFb = static_cast<gamescope::CDRMFb *>( (pLayer->tex && pLayer->tex->GetBackendFb()) ? pLayer->tex->GetBackendFb()->Unwrap() : nullptr );
if ( pDrmFb == nullptr )
{Not sure whether the suggested fix is appropriate or not, @misyltoad please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can eg. init Gamescope headlessly then transition into a backend that only uses SAMPLED modifiers like SteamVR.
This way we can init VRWebHelper in a Gamescope before SteamVR fully comes up.